RDFLib / sparqlwrapper

A wrapper for a remote SPARQL endpoint
https://sparqlwrapper.readthedocs.io/
Other
520 stars 122 forks source link

Test CI: travis CI -> GitHub Actions #175

Closed eggplants closed 2 years ago

eggplants commented 2 years ago

Test run: https://github.com/eggplants/sparqlwrapper/actions/runs/1651950750

eggplants commented 2 years ago

image

eggplants commented 2 years ago

nose is not working in Python 3.10 due to AttributeError: module 'collections' has no attribute 'Callable'.

Maybe it has been not maintained since 2016: https://github.com/nose-devs/nose

aucampia commented 2 years ago

nose is not working in Python 3.10 due to AttributeError: module 'collections' has no attribute 'Callable'.

yes we did a huge overhaul on the main repo (https://github.com/RDFLib/rdflib) - will have to do same here.

eggplants commented 2 years ago

For continued development, I think we need to replace nosetests with pytests.

aucampia commented 2 years ago

that is what we did in https://github.com/RDFLib/rdflib - any PRs to do the same here will be welcome.

eggplants commented 2 years ago

I have just changed testing tool from nose to unittest.

eggplants commented 2 years ago

https://github.com/eggplants/sparqlwrapper/actions/runs/1653813870

177

eggplants commented 2 years ago

𝙍𝙚𝙖𝙙𝙮 𝙛𝙤𝙧 𝙧𝙚𝙫𝙞𝙚𝙬…

nicholascar commented 2 years ago

@eggplants so are you saying that if you reject those changes proposed by @aucampia and keep using unittest instead of nose then everything works fine? If so, we should stick with unittest here for now? I'm happy with that.

eggplants commented 2 years ago

@nicholascar Yes. It looks like the tests under test/ was written in such a way that it was ok to use unittest instead of nose.

nicholascar commented 2 years ago

OK, well then let's merge in now and see if the actions work nicely. So I'll merge and we should put in another small PR after this one to test things out.

aucampia commented 2 years ago

Looking at failure on master now, will make a PR to fix shortly.