RE-SS3D / SS3D

Space Station 3D, another remake of SS13, but with an extra D.
https://ss3d.space/
252 stars 139 forks source link

Player can interact with stored items #1220

Open iamteapot422 opened 1 year ago

iamteapot422 commented 1 year ago

Steps to Reproduce

  1. Comment string 201 in Items.cs (it's not important, but you will know where to click).
  2. Launch the game and spawn two toolboxes.
  3. Put one toolbox into another.
  4. Click on the stored toolbox and see that you took it in hand.

https://github.com/RE-SS3D/SS3D/assets/77565416/e992552d-e172-416b-b97f-af7196de8181

Possible Solution

Turn off all interactions if SetVisibility(false) in Item.cs is called

stilnat commented 1 year ago

@iamteapot422 Currently when putting a toolbox into another, the toolbox just don't show, because of @SurgioGolespi commit. The first issue is the ability to do such a thing (putting a toolbox into another) but we can't do anything without having a common agreement on how should the containers works. Plus we might want some displayed items in container to be interactable. Removing bug and adding needs discussion.

cosmiccoincidence commented 11 months ago

@stilnat can you explain where the lack of agreement is for those of us who are out of the loop? Then we can discuss here in this issue about what to agree on.

stilnat commented 11 months ago

the lack of agreement is mostly regarding the representation of volume and/or dimensions of a container. What makes a container able, or not, to contain another thing, volume wise ?