RE-SS3D / SS3D

Space Station 3D, another remake of SS13, but with an extra D.
https://ss3d.space/
256 stars 137 forks source link

Put audio system back #1320

Closed stilnat closed 11 months ago

stilnat commented 11 months ago

Summary

credits to @EikoBiko #899 for the original PR. This PR intends to put the audio manager back into SS3D.

PR checklist

Pictures/Videos)

Messing around with everything with sound in the PR :

https://github.com/RE-SS3D/SS3D/assets/14344825/fabf51ac-04f9-45b5-86b6-b2381fcbaaf1

Messing around with ambient sounds :

https://github.com/RE-SS3D/SS3D/assets/14344825/8d96df95-1d66-4467-bf2c-1c5019bd72e1

Testing

Test the sound syncing by muting host, performing action with host and checking that client get the sound.

Networking checklist

Changes

Known issues

cosmiccoincidence commented 11 months ago

Please remember to add gitbook documentation on this.

Also, Im tasking you with turning the known issues into github issues (including the lobby ambience sound one) since you know a bit more about the issues than me.