search

RE-SS3D / SS3D

Space Station 3D, another remake of SS13, but with an extra D.
https://ss3d.space/
252 stars 139 forks source link

Cant search for items in tilemap menu #1363

Closed cosmiccoincidence closed 9 months ago

cosmiccoincidence commented 9 months ago

Current Behavior

When you try to search for many items by name in the tilemap menu, they are not properly registering via search.

In the video I first go to the items page (not necessary) to show there are 2 gloves. I then try to search for gloves and the moment I type "g" and only one glove shows up, I continue writing the word "glove" and it no longer shows up.

https://github.com/RE-SS3D/SS3D/assets/41941008/c5fa9555-a0c1-48f5-9fe5-13b2010519c9

Steps to Reproduce

Open the tilemap menu using b and go to the items page and look for an item then trying searching for it in the search bar.

Solution

cosmiccoincidence commented 9 months ago

Apparently the search is case sensitive so by searching "Glove" you are able to find the gloves.

stilnat commented 9 months ago

search case is sensitive and is using the "name string" of the items scriptable objects. Please remove that field and replace it with simply getting the game object name to complete this issue.

image

jckling commented 9 months ago

nameString in ItemObjectSo is inherited from GenericObjectSo, should it be removed in GenericObjectSo?

If should, also need to change these to use object name

image

stilnat commented 9 months ago

@jckling yes it should, thanks for pointing that out. Maybe keep name string but as a property, returning the prefab's name.