RE-SS3D / SS3D

Space Station 3D, another remake of SS13, but with an extra D.
https://ss3d.space/
249 stars 138 forks source link

Fix container display syncing on late joining clients #1427

Closed Sjerty closed 5 months ago

Sjerty commented 5 months ago

[WIP]

Summary

PR checklist

Testing

Host and late join as a client.

Networking checklist

Changes

Changed Start() to Awake() in ContainerItemDisplay.cs, so the listeners could subscribe before the any events happen.

closes #1232

Sjerty commented 5 months ago

Tried to make pivots by hand, instead in Instantiating them in code, almost works fine... Sometimes the client is still spawns with items in the ground, but the host ones from client perspective is fine, still trying to understand why

Also the "Transform[] Displays" in AttachmentContainer.cs not synced for late join, so the first drop of an item is broken. Video: https://www.youtube.com/watch?v=fNmeHWaF8es

stilnat commented 5 months ago

good work, thanks !