search

REAndroid / APKEditor

Powerful android apk editor - aapt/aapt2 independent
Apache License 2.0
847 stars 127 forks source link

Merge leaves split related options in AndroidManifest.xml #114

Closed HelloKS closed 1 month ago

HelloKS commented 1 month ago

Describe the bug After merging X (twitter) 10.52.0, APKEditor leaves "android:requiredSplitTypes" and "android:splitTypes" in AndroidManifest.xml. This resulting non-installable APK.

To Reproduce Steps to reproduce the behavior:

  1. Using APKEditor v1.3.8 on Windows 11, OpenJDK Termurin-21.0.2
  2. Run java -jar APKEditor-1.3.8.jar m -i com.twitter.android_10.52.0-release.0-310520000_4arch_7dpi_23lang_f0692c4e75b3b936319464d7756ffa31_apkmirror.com.apkm
  3. Run java -jar APKEditor-1.3.8.jar d -t xml -dex -i com.twitter.android_10.52.0-release.0-3 10520000_4arch_7dpi_23lang_f0692c4e75b3b936319464d7756ffa31_apkmirror.com_merged.apk
  4. Open AndroidManifest.xml and observe android:requiredSplitTypes and android:splitTypes are still intact after sanitizing

Used apk bundle file APKMirror

Additional context Merging previous version (X 10.51.1) works well and installable

REAndroid commented 1 month ago

For some reason playstore was using requiredSplitTypes & splitTypes attributes without resource id (handled by #85), using proper resource id is a new change.

Fixed by this commit, build your own or grab from action until next release.

Thank you for reporting

REAndroid commented 1 month ago

I assumed this issue is fixed, closing ... reopen it otherwise