search

REAndroid / ARSCLib

Android binary resources read/write library
Apache License 2.0
227 stars 48 forks source link

Consider using correct plural form for "child" #56

Closed naxitoo closed 1 year ago

naxitoo commented 1 year ago

The purpose of this PR is to improve the readability and mantainability of the code.

If "childes" was an intentional misspelling or refers to something else, then please ignore and close it.

REAndroid commented 1 year ago

This is intentional, all methods with child/childes are supposed to be internal/protected. I tried to preserve common method names like size(), getElements() ... for end use. Since this lib uses a lot of hierarchical structures and such names are scarce. for example on this structure TableBlock > PackageBlock > TypeBlock if you call TableBlock.getChildes() you will get different headers, string pools ... instead of an array of PackageBlock

naxitoo commented 1 year ago

Oh, alright, thanks for the explanation, closing PR!

Btw, you're doing an amazing job with this project, keep up :)