search

REBELinBLUE / deployer

Deployer is a free and open source deployment tool.
http://phpdeployment.org
MIT License
909 stars 185 forks source link

[Feature] Laravel Dusk tests #336

Open bbashy opened 7 years ago

bbashy commented 7 years ago

Would you be willing to add Laravel Dusk tests to this project?

I've written a good number of tests on some projects and I know you love testing so hopefully I can get the ball rolling (pun intended).

REBELinBLUE commented 7 years ago

Absolutely, you'll notice the Browser folder exists in tests/, I just didn't want to look at it until I start on rewriting the horrendous javascript 😂

bbashy commented 7 years ago

That's a good point. Were you going to redo some front-end elements as well?

I can start writing some basic ones just for forms if you wanted? Maybe some folder structure ideas.

REBELinBLUE commented 7 years ago

I hadn't planned to change the UI in any way

bbashy commented 7 years ago

JavaScript shouldn't modify the elements a lot then?

REBELinBLUE commented 7 years ago

Fair point, it shouldn't

cerw commented 7 years ago

Isn't this more for phptesting.org ?

bbashy commented 7 years ago

@cerw You're thinking about it the other way around I think? This issue is for adding actual dusk tests to deployer repo, not deployment.

cerw commented 7 years ago

@bbashy sorry my bad. I just implemented my dusk tests on https://github.com/block8/phpci , its tricky one, be great to know how guys implementing it on CI