search

REC-SPb-ETU / Gpstk-old

Other
3 stars 1 forks source link

RinexDatum wrong processing #14

Closed jonyrock closed 9 years ago

jonyrock commented 9 years ago

It it duplicated here https://github.com/REC-SPb-ETU/Gpstk/blob/7eacce1d43d00a40a8e4721dd5a271af66568ab0/dev/ext/lib/FileHandling/RINEX3/Rinex3ObsData.hpp#L64

and here https://github.com/REC-SPb-ETU/Gpstk/blob/7eacce1d43d00a40a8e4721dd5a271af66568ab0/dev/ext/lib/FileHandling/RINEX/RinexObsData.hpp#L66

and wrong written in Rinex3ObsData here:

https://github.com/REC-SPb-ETU/Gpstk/blob/7eacce1d43d00a40a8e4721dd5a271af66568ab0/dev/ext/lib/FileHandling/RINEX3/Rinex3ObsData.cpp#L325

I do understand why the developers did this, but there are errors. Sometimes is used "different" structure when obviously should be used other.

because we have isEmpty state for RinexDatum now to handle error: the right way to put record is to write spaces instead of zero.

jonyrock commented 9 years ago

I decided to declare a new class called Rinex3Datum so be little bit more explicit which class do we us. Also I keep splitted logic as developers wanted. And a restored previous RinexDatum