search

REC-SPb-ETU / Gpstk-old

Other
3 stars 1 forks source link

fstream to basic_iostream in RinexStream #3

Open jonyrock opened 9 years ago

jonyrock commented 9 years ago

There is https://github.com/jonyrock/Gpstk/blob/master/dev/ext/lib/FileHandling/FFStream.hpp which base for all FF* classes. I suppose we need also change lib/FileHandling to lib/DataHandling

jonyrock commented 9 years ago

@eugenyk I want to underline that we can't change FFStream interface, so the original constructors should remain.

jonyrock commented 9 years ago

http://tool.oschina.net/uploads/apidocs/cpp/en/cpp/io/basic_streambuf.html http://en.cppreference.com/w/cpp/io/basic_streambuf

jonyrock commented 9 years ago

@eugenyk please review the changes. Looks like it works. I think that the heart of my solution is dev/ext/lib/FileHandling/FFStream.hpp (see all diff of this file) and here https://github.com/jonyrock/Gpstk/blob/bfd61eb6d30adb3bdfb07fc38bc8ff02bdcfeed0/dev/ext/lib/FileHandling/FFStream.cpp#L70

eugenyk commented 9 years ago

Sources reviewed, comments added. std::iostream inheritance really looks more consistent