RECETOX / galaxytools

Set of Galaxy tool wrappers developed at RECETOX
MIT License
13 stars 13 forks source link

Update recetox-aplcms to v0.10.3 #329

Closed xtrojak closed 1 year ago

xtrojak commented 1 year ago

This PR covers:

Close #327. Close #326. Close #291. Close #328.

hechth commented 1 year ago

@xtrojak one more thing to have a look at is the noise percentile - we actually can't provide NA as a value since it is a numeric field

xtrojak commented 1 year ago

@xtrojak one more thing to have a look at is the noise percentile - we actually can't provide NA as a value since it is a numeric field

You are completely right, the help text of baseline_correct is misleading. What we can do is make the parameter optional. Then if not value is given, we pass NA.

But I'm wondering if this makes sense. I feel like two things are kind of mixed here - either use threshold or percentile. But this issue is already on the level of the package.

xtrojak commented 1 year ago

You are completely right, the help text of baseline_correct is misleading. What we can do is make the parameter optional. Then if not value is given, we pass NA.

@hechth in 60a8c95, I made the parameter baseline_correct optional as suggested, and when value is not given, NA is passed.