RECETOX / recetox-aplcms

This is a custom fork of apLCMS containing adaptations for large scale studies.
GNU General Public License v2.0
4 stars 8 forks source link

Implemented new version for clustering #201

Closed hechth closed 1 year ago

hechth commented 1 year ago

Closes #198 Closes #199

hechth commented 1 year ago

@hechth Why did you remove all the .Rd files in cec9f8a?

They are auto generated anyway, so I think they just increase the repository size unnecessarily

xtrojak commented 1 year ago

@hechth Why did you remove all the .Rd files in cec9f8a?

They are auto generated anyway, so I think they just increase the repository size unnecessarily

I thought they are maybe needed somewhere, but I guess you are right. Would be nice to note this in the changelog.

zargham-ahmad commented 1 year ago

@hechth Does deleting man files really make any difference in the repo size because they were around 80 kb anyways? Also, I think the CI seems to be failing because of it No man pages found in package ‘recetox.aplcms’

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.34% and project coverage change: -0.29 :warning:

Comparison is base (0543377) 66.13% compared to head (d840dd7) 65.84%.

:exclamation: Current head d840dd7 differs from pull request most recent head b5a61ce. Consider uploading reports for the commit b5a61ce to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #201 +/- ## ========================================== - Coverage 66.13% 65.84% -0.29% ========================================== Files 23 23 Lines 2616 2685 +69 ========================================== + Hits 1730 1768 +38 - Misses 886 917 +31 ``` | [Impacted Files](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX) | Coverage Δ | | |---|---|---| | [R/adjust.time.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9hZGp1c3QudGltZS5S) | `63.63% <ø> (ø)` | | | [R/find.tol.time.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9maW5kLnRvbC50aW1lLlI=) | `48.00% <ø> (-42.00%)` | :arrow_down: | | [R/prof.to.features.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9wcm9mLnRvLmZlYXR1cmVzLlI=) | `87.19% <0.00%> (ø)` | | | [R/remove\_noise.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9yZW1vdmVfbm9pc2UuUg==) | `58.33% <ø> (ø)` | | | [R/compute\_clusters.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9jb21wdXRlX2NsdXN0ZXJzLlI=) | `89.15% <100.00%> (+7.52%)` | :arrow_up: | | [R/feature.align.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9mZWF0dXJlLmFsaWduLlI=) | `96.38% <100.00%> (ø)` | | | [R/find\_mz\_tolerance.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9maW5kX216X3RvbGVyYW5jZS5S) | `96.77% <100.00%> (ø)` | | | [R/hybrid.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9oeWJyaWQuUg==) | `100.00% <100.00%> (ø)` | | | [R/recover.weaker.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui9yZWNvdmVyLndlYWtlci5S) | `98.32% <100.00%> (ø)` | | | [R/unsupervised.R](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX#diff-Ui91bnN1cGVydmlzZWQuUg==) | `99.29% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/RECETOX/recetox-aplcms/pull/201?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RECETOX) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.