search

RECETOX / recetox-xMSannotator

This is a custom adaptation of the original version of xMSannotator. It is a complete rewrite of the original functionality, following the same program structure.
GNU General Public License v3.0
5 stars 6 forks source link

Peak correlation matrix: Likely to go out of bounds for large peak tables #95

Open hechth opened 2 years ago

hechth commented 2 years ago

For large peak tables, the computation of the correlation matrix might produce very large outputs - this is the same problem as in the RAMClustR package.

Maybe it would make sense to find some common sparse correlation matrix implementation?

hechth commented 2 years ago

@xtrojak now since this is fixed in RAMClustR, do you think this could also be done in xMSannotator?

xtrojak commented 2 years ago

@hechth just to clarify, we are just talking about memory consumption optimisation, otherwise it works fine in xMSannotator? Or was there any case when a run failed for insufficient memory?

hechth commented 2 years ago

No - this is just a preliminary "issue" on GitHub since I expect to run into similar problems with xMSannotator as with RAMClustR.