search

REGmon-project / regmon

Athlete Monitoring in Sport Practice and Research
https://regmon-project.github.io/
MIT License
6 stars 1 forks source link

note properties and behaviour #3

Open ChristianStrotkoetter opened 11 months ago

ChristianStrotkoetter commented 11 months ago

If I understand correctly, notes follows the same logic as any single form-element, since - if selecting them for results display - they are a column with timestamps as well. But they have "showingraph"-property and as far as I understand, this property is used in data selection processes to filter displayable/exportable notes (forms_results.php/results.php/export.php).

[By the way, is the "status"-property of forms_data entries (changeable by "(de)activate entry") used with the same logic?]

This behaviour is creating some problems, because in general notes should always be selectable/exportable, regardless of their "showingraph"-property. I am aware that the simplest approach to not show a note in the graphic is to exclude them in corresponding data tables. However, the initial idea was that the "showingraph"-property should only be used to change the visibilty of certain notes in graphs, not excluding them in data tables.

Right now, I don't have a good idea of how this might be solved/changes. Maybe one way would be to always include all notes in data tables and disable the view showingraph=0-notes during the plotting process. Anyway, users wouldn't see this property in forms_results/results-pages, which would be confusing. Another way would be to split single notes into single "data frames" to set the "show in graph"-property according to their showingraph-value. This might collide with templates, since one is set in notes-table and the other in templates-tables.

What do you think?

ChristianStrotkoetter commented 11 months ago

[reply by madnetdev]

As I remember and as I see the code it seems that if the showInGraph is false then means that cannot export too. It is like a private note for Athlete and Trainer and they not want be visible to others.

Now if the showInGraph is true you can enable disable from the "Show in Diagram" checkbox. I think that this is the logic and it makes sense to me.

ChristianStrotkoetter commented 11 months ago

Okay,

It is like a private note for Athlete and Trainer and they not want be visible to others.

it's a good way to think about it, I'm fine with this.

Could you add something like a hover-over for "Show note in diagrams?" (same as for "? Lines"), where we put some explanation? Something like "If disabled, this note is private. If enabled, this note will in principle be exportable and displayable in graphics, while the corresponding permissions for connected trainer-profiles still apply."

ChristianStrotkoetter commented 11 months ago

[reply by madnetdev]

Maybe the "Show note in diagrams?" should be "Private Note" and an explanation one line below "Private Notes cannot be exported and cannot be used in Diagrams" or something like that, but this way, athlete may think the Trainer cannot see the notes.

We need to find out why we put this. What was the logic when we put it.