REGnosys / rosetta-code-generators

Write code generators for any language, based on the rosetta DSL
Apache License 2.0
17 stars 33 forks source link

Generated JSON schema is incorrect #295

Open dmostert-gresham opened 6 months ago

dmostert-gresham commented 6 months ago

Description

The generated JSON schema does not define the "value" child element that is needed to reconstruct a ReportableEvent/TransactionReportInstruction object from JSON data.

See the attached screenshot: the sample ReportableEvent JSON has a "value" child under "before", but this is not visible in the tree hierarchy at the top. Seems to be inferred when the rosetta files contains [meta reference]

Screenshot 2024-05-07 at 08 50 01

Is this a regression?

No

Expected behaviour

The "value" child must be defined in the JSON schema

Steps to reproduce

  1. Run json schema generator

🌍 Your Environment


-OS i.e. macOS Sonoma version 14.4.1
-IDE details, i.e IntelliJ IDEA 2024.1
-Maven version i.e. 3.6.3