REGoth-project / REGoth

OpenSource-Reimplementation of the zEngine, used by the game "Gothic"
GNU General Public License v3.0
631 stars 62 forks source link

Restructuring engine parts #239

Closed ErrorFlexXx closed 6 years ago

ErrorFlexXx commented 7 years ago

To sharpen the module structure of the project, I started moving some parts to other classes.

My concept is:

This way I can use the BaseEngine for a Multiplayer server implementation for example without the need to init a renderer or have a sound card initialized and of course without tons of #ifdefs or regular ifs.

For a later multiplayer implementation I want to create different programs via the target directory and use as much as possible the existing structures, than creating modified copies of all things.

Regards.

ataulien commented 7 years ago

Uh, why does the "removed unused gamesession"-commit contain everything we did in the last days? That commit is HUGE!

ErrorFlexXx commented 7 years ago

The commit "removed unused gamesession", contains the deletion of one #include in my view ...?

Edit: Oh, sorry. This was the condensed view : / Now I see what you mean..

Now, I know what happend: To create a pull request, which can be pulled in without conflicts, I pulled the current Master of REGoth. This way I got the latest accepted pull request and commits and integrated it with my changes. I forgot to commit after pulling the master, so all the changes are signed with the commit title of the "removed unused GameSession include". Next time I will create a dedicated pull commit for that update.