REGoth-project / REGoth

OpenSource-Reimplementation of the zEngine, used by the game "Gothic"
GNU General Public License v3.0
630 stars 63 forks source link

Video player #346

Open mplucinski opened 6 years ago

mplucinski commented 6 years ago

Hi all,

I've been observing your project for a long time, but only recently had time for any significant contribution. I noticed that REGoth completely lacks video playing capability for in-game clips and decided to try to fill in the gap.

This patchset implements the basic video playing capability. The functionality is pretty straightforward: when an appropriate Daedalus function is triggered, the video player kicks in and play the clip.

Some more details:

I'm looking forward for feedback, especially regarding the architectural decisions and aforementioned matter of the integration with the existing audio system.

BR, Mariusz

ataulien commented 6 years ago

Heh, I started some work on that myself (see video-playback-branch: https://github.com/REGoth-project/REGoth/tree/video-playback), but only quickly hacked some stuff together to make it work.

I implemented an UI-view for videos, but the video completely blocked the game while it played, from withing the UI-view. (not so nice). Also, no sound, wrong framerate.

It seems that there are no very simple small ffmpeg based video-player libraries out there, so I made my own one (based on some sample code I found): https://github.com/REGoth-project/FfmpegVideoPlayer

So, maybe some of my stuff is helpful for you. I'm actually glad someone else is working on this, ffmpeg is not for me as it seems! 😄

tomedi commented 6 years ago

@mplucinski Hey man, I've tried to test your video player- unfortunately, I couldn't do it. It's not possible to start videos with the AppVeyor artifact.