RENCI / ctmd

MIT License
2 stars 0 forks source link

Give HEAL WRITE permissions to Suzanne Aycock #449

Open dcarsey opened 3 years ago

dcarsey commented 3 years ago

Suzanne.Aycock@duke.edu

https://heal-ctmd.renci.org/?status=success&username=suzanne.aycock@duke.edu%20&organization=Duke%20University&access_level=4&first_name=Suzanne&last_name=Aycock&email=suzanne.aycock@duke.edu%20

Check the README

REMEMBER THAT THESE ARE CASE SENSITIVE

Other info from our previous discussions on this:

I looked at the QI WRT how to add someone w/ HEAL write permissions. Since we are having trouble w/ adding this Suzanne person, and now that I’m reading the instructions and see “API” in it, I just want to ask out loud, as a layman…: if our API set-up has changed, does that mean that these instructions have changed???

To update list of heal users with write permissions: edit the heal_users.txt in the api folder and add the email address of the person in a newline who has write access now. Then run docker-compose -f docker-compose.prod.yml up --build -d -V --no-deps api so that the api reads the file again. (We may want a refresh endpoint at some point).

mbwatson commented 3 years ago

i think i found why this fails.

the helper function checks converts the email to lower-case before comparison:

https://github.com/RENCI/ctmd-dashboard/blob/5badf320beab00d2a95b18107157923ed8d7eca8/api/utils/helpers.js#L37

while the emails read from file are not:

https://github.com/RENCI/ctmd-dashboard/blob/5badf320beab00d2a95b18107157923ed8d7eca8/api/utils/helpers.js#L27


this particular email is in the file with upper- and lower-case characters, so equality with the lower-cased version fails.

mbwatson commented 3 years ago

@dcarsey i submitted a pull request to address this. i didn't mean to take this issue from you, @rajshruti18 ! the code change was a one-liner, so i just went ahead and submitted it.

dcarsey commented 3 years ago

Rawr. This problems persists for Suzanne Aycock. Re-opening the tix.

dcarsey commented 3 years ago

From 7-14-21 == still didn't work

image