Closed krobasky closed 2 years ago
I've implemented some of these. We can discuss the others.
Regarding the data download: if we are not going to enable downloading the phenotype and expression data (note that these are still available via the API if users really want it...), should we just remove the Download Data page and move the download CellFIE output button to the CellFIE output panel?
@LauraCapps let's add this to the agenda for discussion with Immunespace guys: "can we allow users to download the data they import and transform from Immunespace"
@davidborland ... "import" is a good word, if you want to use that instead of "retrieve" - I see you've already made the changes to "retrieve", so its your call if you want to change it again. Either seems good to me.
David, one more:
I like import. Will go with that for now. I'm less inclined to CellFIE run output in the various places, as it is more verbose, and I think CellFIE output works on its own. We can discuss though.
I agree with you, but "CellFIE output" doesn't seem quite right, it doesn't indicate that each run has its own output, and it doesn't generalize well to other tools like PCA. How about "CellFIE resultset"? Then you might also have "PCA resultset", and you might somehow indicate the run_id that resultset is tied to, in case you want to check the parameters and dataset you used or something.
Glossary of terms from this ticket disucssion:
We need to capture this in a google to allow it to evolve and drive any necessary changes to the API
@davidborland I captured the above in the txscience co-work team meetings, we can add/modify it from there
https://docs.google.com/document/d/1UBQmzMnQvjfAD_nl9SKDimW0bcSOFv2BV1ncP4XWWH0/edit
Implemented
Upload/Download is confusing because we "upload" from our computer to ImmCellfie, but we "download" data from immunespace into immcellfie, and we also "download" data from ImmCellfie. Task/output" is also confusing because we use it to mean
On the "Data Source" -> "Immunespace" screen (see below):