search

RENCI / pds

PDS application (tx-router plugin)
MIT License
1 stars 0 forks source link

[Feature] pdspi-guidance-example-gentamicin is private and uses Phase 1 API #132

Open krobasky opened 4 years ago

krobasky commented 4 years ago

Which repo (e.g., tx-logging)? pdspi-guidance-example-gentamicin

Expected Behavior all pds repos should be public

Information I renamed pdspi-guidance-example to pdspi-guidance-example-gentamicin so that we can have a 'stub' repo named pdspi-guidance-example.

Meanwhile, I want to make pdspi-guidance-example-gentamicin public, but I want to let you do it, @ryanoconnor285 in case you have any private information you prefer to remove first.

You'll also need to reconcile the API with the phase 2 API, see #131, and talk to me. How we integrate the notion of a decision tree with the phase 2 API is TBD.

To close this ticket, first make the repo public, then:

  1. Add the 'config' endpoint and add the Config schema, filling in the 'default' values appropriately.
  2. Add the 'GuidanceInputs' schema, and consume any data therein appropriately
  3. Update how the Guidance is returned, per #131, talk to me if you have questions; we may get more clarity on format after talking with Greg Kuhnen and his assigns for CDS Hooks (cds-hooks)
  4. test cases for calling the endpoints are deployed and configured for autotest/autobuild on dockerhub for v0.2.0 (stable release) and 'unstable' (master branch), using the file 'env.TAG' in the ./pdspi-guidance-example-gentamicin (see tx-router/env.TAG and tx-router/test/test.sh for example code)
  5. the new plugin is deployed on pds.renci.org and both endpoints are fully working with the deployed containers for pds
  6. all the environmental variable values in all the Docker and docker-compose.yml files are set using variables (not hard-coded) (see tx-router/test/test.sh and tx-router/test/docker-compose.yml for examples)
  7. the pdspi-guidance-example-gentamicin repo docker-compose.yml files are pointing to the :unstable version of dependent containers.
  8. there is documentation on the pdspi-guidance-example-gentamicin repo README on how to install/configure/deploy (can be pointing to other repos), especially HOW to set the environmental variables that are required by the Docker and docker-compose.yml files
  9. Somebody on the team has done a code-review and an acceptance test of the solution
ryanoconnor285 commented 4 years ago

Obsolete? PDS config api is being handled by Hao. I wasn't able to find them but I believe these are duplicates of older tickets