search

RENCI / xDCIShare

xDCIShare is a collaborative website being developed for better access to data and models of scientific domains. xDCIShare is derived directly from the NSF-funded HydroShare codebase.
https://www.xdcishare.org
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Revert commit 3501cef #68

Closed cbcunc closed 7 years ago

cbcunc commented 7 years ago

We need to revert commit 3501cef3fc2358fd42ca91ec85f479937ee7062c added by #49. This commit changed the docker container names. On it's own, that's OK. But it also breaks a lot of ancillary scripts. The reasoning for the commit was to "support HS & XDCI simultaneously." However xDCIShare and hs should not be run in the same VM. If that were the case, there would also need to be similar container renaming of every fork of xDCIShare. It's simpler to keep the simple container names that are the same across all forks and not run them in the same VM.

cbcunc commented 7 years ago

Merged in #69.

cbcunc commented 7 years ago

Ref: @alexlemann