RESQUE-Framework / website

The Research Quality Evaluation Scheme
https://resque-framework.github.io/website/
MIT License
2 stars 3 forks source link

Add validation to all 'pick' functions #10

Open alpkaanaksu opened 11 months ago

alpkaanaksu commented 11 months ago

Felix:

Do we need a minimal validation of the definition-json?

I imagine the scenario, that a committee removes a set of items (which they don't want), but thereby break the logic of points, as another item refers to a deleted item in a condition.

All pick functions should handle this. It is as simple as iterating through all selected indicators and check if indicators that are mentioned in the 'condition' field come before the indicator we are currently inspecting.