RESQUE-Framework / website

The Research Quality Evaluation Scheme
https://resque-framework.github.io/website/
MIT License
2 stars 3 forks source link

Split "Own data or data reuse (check all that apply)"? #25

Closed nicebread closed 10 months ago

nicebread commented 11 months ago

The "Own data or data reuse (check all that apply)" indicator is a bit strange:

Actually it is a forced choice/mandatory indicator, as at least one option must be clicked - either "no data", or one or more of the first 3 options. At the moment, it is possible to select nothing.

How can we solve that?

Idea: Split into more questions:

Q1a: Does this paper use any kind of data in a substantive way (new data, reuse of existing data, or simulated data?) --> Yes / No Q1b (if yes in Q1a): What kind of data do you use? (check all that apply) ☐ Own new data collection ☐ Reuse of own existing data set ☐ Reuse of someone else's existing data set ☐ Simulated data --> here, a validation would be that at least one of the checkboxes needs to be selected.

Q1c (see email from Anne): Type of data (check all that apply): ☐ Questionnaire ☐Behavioral ☐Physiological / Biological ☐ Other: (+textfield)

alpkaanaksu commented 10 months ago
{
            "id": "P_Data",
            "type": "radio",
            "title": "Does this paper use any kind of data in a substantive way (new data, reuse of existing data, or simulated data?)",
            "options": [ "No", "Yes" ],
            "condition": "$P8"
        },
        {
            "id": "P_Data_Source",
            "type": "checkbox",
            "title": "What kind of data do you use? (check all that apply)",
            "options": [
                { "id": "NewOwn", "text": "Own new data collection" },
                { "id": "ReuseOwn", "text": "Reuse of own existing data set" },
                { "id": "ReuseOther", "text": "Reuse of someone else's existing data set" },
                { "id": "Simulated", "text": "Simulated data" }
            ],
            "min_selected": 1,
            "info": "Data set acquisition often is a collaborative enterprise with different contributor roles. { $P_Data_Source_ReuseOwn | Select 'Reuse of own existing data set' only, if you would qualify as a co-author with substantive contributions in a stand-alone data set publication of that data set. }",
            "condition": "$P8 && $P_Data"
        },
        {
            "id": "P_Data_Type",
            "type": "checkbox",
            "title": "Type of data (check all that apply)",
            "options": [
                { "id": "Questionnaire", "text": "Questionnaire" },
                { "id": "Behavioral", "text": "Behavioral" },
                { "id": "Physiological / Biological", "text": "Physiological" },
                { "id": "OtherType", "text": "Other [please specify]" }
            ],
            "condition": "$P8 && $P_Data"
        },
        {
            "id": "P_Data_Type_Other",
            "type": "text",
            "title": "Type of data: Other",
            "condition": "$P8 && P_Data && P_Data_Type_OtherType"
        },

Use of these new items requires an updated id handling logic for checkboxes (related to #32) and an implementation of "min_selected" check for checkboxes.

alpkaanaksu commented 10 months ago
Screenshot 2023-09-04 at 16 36 21 Screenshot 2023-09-04 at 16 37 11
alpkaanaksu commented 10 months ago

I implemented the 'min_selected' functionality 3fe83e471d4e01e77c669b803a489bebc941284c

Screenshot 2023-09-19 at 21 11 45