Get rid of all scores / one point is left over?

RESQUE-Framework / website

The Research Quality Evaluation Scheme

https://resque-framework.github.io/website/

MIT License

2 stars 3 forks source link

Get rid of all scores / one point is left over? #27

Closed nicebread closed 11 months ago

nicebread commented 11 months ago

If I select "not applicable" where ever possible, still 1 point is left. I don't know where this comes from?

See attached file (rename to .json, as a json upload is not possible here).

resque_1693372668078.txt

alpkaanaksu commented 11 months ago

I think that one point comes from P16. Fixing it should be as easy as copying the not_applicable condition of P15 (since P16 is also not applicable, if P15 is not applicable)

nicebread commented 11 months ago

Fixed in 81fbce7b27608a0d06c3278d26870d90222f0c65.

When scores are down to 0, the score box says "No score - applicant requests manual processing", even if P8 has not been checked. But if everything is "not applicable", this boils down to manual processing. Hence, the message seems appropriate.

alpkaanaksu commented 11 months ago

'No score' is shown if max score is 0.