search

RESTful-Drupal / restful

RESTful best practices for Drupal
https://drupal.org/project/restful
419 stars 173 forks source link

Test are broken on 7.x-1-x #991

Closed alvar0hurtad0 closed 7 years ago

alvar0hurtad0 commented 7 years ago

After this (https://github.com/RESTful-Drupal/restful/commit/7420a347472bfb6d979337a3585cb71599b3ec40) commit RestfulCsrfTokenTestCase test fails.

Those are the failing assertions:

 POST http://restful/api/v1.0/articles returned 200 (161 bytes).
Fail      Other      RestfulCsrfTokenT  102 RestfulCsrfTokenTestCase->checkCsrf
    400 on POST without CSRF token for authenticated user.
    POST http://restful/api/v1.0/articles returned 200 (161 bytes).
Fail      Other      RestfulCsrfTokenT  112 RestfulCsrfTokenTestCase->checkCsrf
    403 on POST with invalid CSRF token for authenticated user.
    POST http://restful/api/v1.0/articles/7 returned 201 (164 bytes).
Fail      Other      RestfulCsrfTokenT  102 RestfulCsrfTokenTestCase->checkCsrf
    400 on PUT without CSRF token for authenticated user.
    POST http://restful/api/v1.0/articles/8 returned 201 (164 bytes).
Fail      Other      RestfulCsrfTokenT  112 RestfulCsrfTokenTestCase->checkCsrf
    403 on PUT with invalid CSRF token for authenticated user.
    POST http://restful/api/v1.0/articles/10 returned 201 (167 bytes).
Fail      Other      RestfulCsrfTokenT  102 RestfulCsrfTokenTestCase->checkCsrf
    400 on PATCH without CSRF token for authenticated user.
    POST http://restful/api/v1.0/articles/11 returned 201 (167 bytes).
Fail      Other      RestfulCsrfTokenT  112 RestfulCsrfTokenTestCase->checkCsrf
    403 on PATCH with invalid CSRF token for authenticated user.
    GET http://restful/api/v1.0/articles/13 returned 204 (0 bytes).
Fail      Other      RestfulCsrfTokenT  102 RestfulCsrfTokenTestCase->checkCsrf
    400 on DELETE without CSRF token for authenticated user.
    GET http://restful/api/v1.0/articles/14 returned 204 (0 bytes).
Fail      Other      RestfulCsrfTokenT  112 RestfulCsrfTokenTestCase->checkCsrf
    403 on DELETE with invalid CSRF token for authenticated user.
alvar0hurtad0 commented 7 years ago

@e0ipso do you have any idea about why?

e0ipso commented 7 years ago

No idea… It's been ages since I looked at 7.x-1.x.

To be honest, 7.x-1.x is not deprecated only because I know @amitaibu is fond of it and Gizra is and maintaining this version.

alvar0hurtad0 commented 7 years ago

Thanks for your response @e0ipso.

amitaibu commented 7 years ago

Merged, thanks!