Closed willtoth closed 4 years ago
Hi William, Thanks for fixing this. I notice that you changed the path for <hal/HAL.h> to <hal/hal.h>. Unfortunately, the file name in wpilib really is HAL.h. It is not consistent -- the directory name is lower case but the file name is upper case. -- Carl
On Mon, Jan 20, 2020 at 12:43 PM William Toth notifications@github.com wrote:
Closed #7 https://github.com/REVrobotics/2m-Distance-Sensor/issues/7 via 2d86aa1 https://github.com/REVrobotics/2m-Distance-Sensor/commit/2d86aa10929bbdee6257564a094482f305061e71 .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/REVrobotics/2m-Distance-Sensor/issues/7?email_source=notifications&email_token=AAGLUU4CF2NJIREOJRT4PN3Q6YEF7A5CNFSM4KIWDNI2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWCWT3EQ#event-2964143506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGLUU4KQVRSBC4UWI7USILQ6YEF7ANCNFSM4KIWDNIQ .
So it is, thanks for catching! Probably would have seen once it gets built for 2020
As part of the porting for 2020, please change the include file path for I2C.h. It should be <hal/I2C.h> rather than <HAL/I2C.h>. I am able to compile things using the library successfully on Windows (case-insensitive filenames) but not on linux.
Having a working vendordep.json for 2020 for this library and having it work on linux would greatly simplify our development and continuous integration tooling. Thanks.
Originally posted by @chauser in https://github.com/REVrobotics/2m-Distance-Sensor/issues/6#issuecomment-575943002