search

REVrobotics / 2m-Distance-Sensor

Port of ST vl53l0x driver for roboRIO to operate the REV Robotics 2m Distance Sensor.
http://www.revrobotics.com/rev-31-1505/
BSD 3-Clause "New" or "Revised" License
6 stars 8 forks source link

File path for I2C.h should be <hal/I2C.h #7

Closed willtoth closed 4 years ago

willtoth commented 4 years ago

As part of the porting for 2020, please change the include file path for I2C.h. It should be <hal/I2C.h> rather than <HAL/I2C.h>. I am able to compile things using the library successfully on Windows (case-insensitive filenames) but not on linux.

In file included from /home/hauser/sciborgs-2020/robot-2020/robot/src/subsystems/the_robot/trenchController.h:49:0,
                 from /home/hauser/sciborgs-2020/robot-2020/robot/src/subsystems/the_robot/TheRobotSetup.cpp:32:
/home/hauser/.gradle/caches/transforms-2/files-2.1/deb540110fe5084595fa2d5c06e4659b/DistanceSensor-cpp-0.0.6-headers/rev/Rev2mDistanceSensor.h:38:10: fatal error: HAL/I2C.h: No such file or directory
 #include <HAL/I2C.h>
          ^~~~~~~~~~~
compilation terminated.

Having a working vendordep.json for 2020 for this library and having it work on linux would greatly simplify our development and continuous integration tooling. Thanks.

Originally posted by @chauser in https://github.com/REVrobotics/2m-Distance-Sensor/issues/6#issuecomment-575943002

chauser commented 4 years ago

Hi William, Thanks for fixing this. I notice that you changed the path for <hal/HAL.h> to <hal/hal.h>. Unfortunately, the file name in wpilib really is HAL.h. It is not consistent -- the directory name is lower case but the file name is upper case. -- Carl

On Mon, Jan 20, 2020 at 12:43 PM William Toth notifications@github.com wrote:

Closed #7 https://github.com/REVrobotics/2m-Distance-Sensor/issues/7 via 2d86aa1 https://github.com/REVrobotics/2m-Distance-Sensor/commit/2d86aa10929bbdee6257564a094482f305061e71 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/REVrobotics/2m-Distance-Sensor/issues/7?email_source=notifications&email_token=AAGLUU4CF2NJIREOJRT4PN3Q6YEF7A5CNFSM4KIWDNI2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWCWT3EQ#event-2964143506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGLUU4KQVRSBC4UWI7USILQ6YEF7ANCNFSM4KIWDNIQ .

willtoth commented 4 years ago

So it is, thanks for catching! Probably would have seen once it gets built for 2020