REVrobotics / CANBridge

Generic CAN Bridge emulating FRC netcomm CAN driver for connecting a PC to the CAN Bus with WPILib 2020+ and SPARK MAX (FW 1.5.0 or higher) or other drivers, currently only supported in Windows.
Other
11 stars 5 forks source link

Getting the following compiling issue - anything I'm doing wrong? #10

Closed adimehrotra closed 1 year ago

adimehrotra commented 4 years ago

compiling CANBridge.cpp failed. In file included from /Users/andromeda/Downloads/scout-master/CANBridge/src/main/native/cpp/CANBridge.cpp:46: /Users/andromeda/Downloads/scout-master/CANBridge/src/main/native/include/rev/Drivers/SerialPort/SerialDriver.h:44:25: error: 'GetName' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual std::string GetName() const {return "Legacy";} ^ /Users/andromeda/Downloads/scout-master/CANBridge/src/main/native/include/rev/CANDriver.h:51:25: note: overridden virtual function is here virtual std::string GetName() const = 0; ^ 1 error generated.

willtoth commented 4 years ago

What environment are you using and how are you invoking the build?

Removing -Werror will fix this

adimehrotra commented 4 years ago

Got it working! I just imported the project wrong :)