REVrobotics / CANBridge

Generic CAN Bridge emulating FRC netcomm CAN driver for connecting a PC to the CAN Bus with WPILib 2020+ and SPARK MAX (FW 1.5.0 or higher) or other drivers, currently only supported in Windows.
Other
11 stars 5 forks source link

Update build system for Linux, macOS, overhaul GitHub Actions, remove serial driver #37

Open garrettsummerfi3ld opened 6 days ago

garrettsummerfi3ld commented 6 days ago

This PR introduces a number of changes to the build system and GitHub Actions workflows, as well as removing the unused serial driver.

There are some changes made in this PR that breaks builds for node-can-bridge, plans to update build and CI for node-can-bridge are underway to incorporate Linux and macOS builds for future releases.

PR that addresses these concerns is created at https://github.com/REVrobotics/node-can-bridge/pull/30 for discussion and review.

NoahAndrews commented 6 days ago

Thanks for making this (at first glance) so much easier to review! Going to try to get to this this week.

garrettsummerfi3ld commented 2 days ago

This PR had downstream issues with building node-can-bridge, the PR that addresses this concern has been created here: https://github.com/REVrobotics/node-can-bridge/pull/30