Open garrettsummerfi3ld opened 6 days ago
Thanks for making this (at first glance) so much easier to review! Going to try to get to this this week.
This PR had downstream issues with building node-can-bridge, the PR that addresses this concern has been created here: https://github.com/REVrobotics/node-can-bridge/pull/30
This PR introduces a number of changes to the build system and GitHub Actions workflows, as well as removing the unused serial driver.
main
and PRs tomain
for testing builds on multiple platforms before a PR.Added IOKit linker args for macOS builds to use with the serial driver.Removed Windows-only preprocessor macros on the serial driver for all platforms.There are some changes made in this PR that breaks builds for node-can-bridge, plans to update build and CI for node-can-bridge are underway to incorporate Linux and macOS builds for future releases.PR that addresses these concerns is created at https://github.com/REVrobotics/node-can-bridge/pull/30 for discussion and review.