REVrobotics / SPARK-MAX-Examples

Example code for SPARK MAX
BSD 3-Clause "New" or "Revised" License
105 stars 104 forks source link

restoreFactoryDefaults() is placed after parameters in SPARK MAX sample code #32

Open rowan-asher opened 1 year ago

rowan-asher commented 1 year ago

restoreFactoryDefaults() is called AFTER init and setting motor type to brushless in sample code, as seen here.

This implies (to many students/customers) that they can set all parameters prior to restoring defaults because the sample code does not specify that brushed/brushless is a parameter that is retained upon reset. Sample code (ALL examples) needs to be updated to have parameters set AFTER calling restoreFactoryDefaults(), even if parameters are retained, as it is causing major issues for teams who put all parameters in one place.