search

REVrobotics / SPARK-MAX-Examples

Example code for SPARK MAX
BSD 3-Clause "New" or "Revised" License
106 stars 107 forks source link

Need update for 2024 season #33

Closed gk-brown closed 10 months ago

gk-brown commented 10 months ago

Apparently the 2024 version of wpilib requires a "year" declaration in the vendordeps configuration. Without this, the build produces the following error:

Vendor Dependency REVRobotics has invalid year null. Expected to be 2024.

I was able to work around this by manually adding the following to vendordeps/REVRobotics.json and refreshing the dependency:

"frcYear": "2024"

I added it immediately following the "uuid" value, mirroring the structure of the 2024 WPILibNewCommands.json file.

gk-brown commented 10 months ago

Apparently this change is not sufficient - even though I no longer get the "null year" error, I am unable to reference any com.revrobotics classes. It seems like the dependency is not being pulled in correctly.

jfabellera commented 10 months ago

The vendordep json used for the examples have not yet been updated for 2024 season. The latest version of REVLib is available here.

jfabellera commented 10 months ago

It looks like the README of this repo is out of date for installing REVLib as well, that may explain why you have a REVRobotics.json instead of a REVLib.json.

Please follow the instructions from WPILib for installing 3rd party libraries and use the vendordep URL in the release linked above.

gk-brown commented 10 months ago

@jfabellera Thank you, I will give that a try.

gk-brown commented 10 months ago

Closing since this issue will be resolved by #34.