REditorSupport / languageserver

An implementation of the Language Server Protocol for R
Other
590 stars 93 forks source link

Unit tests hang when using devtools #39

Open andycraig opened 5 years ago

andycraig commented 5 years ago

This only affects development, not the end user.

To duplicate:

With languageserver not installed:

devtools::load_all("languageserver")
devtools::test("languageserver")

Output is:

Loading languageserver
Loading required package: testthat
Testing languageserver
✔ | OK F W S | Context

Then is no progress beyond that.

When languageserver is installed, unit tests complete as expected.

@kforner says (#37):

I think this is because the R process run by https://github.com/REditorSupport/languageserver/blob/master/R/languageclient.R#L18 does not find the package, since it is not installed. But there is not any error check at this point. I propose to add a sleep, then a check that the process is still alive, otherwise raise an execption with the error stream content.

minkir014 commented 5 years ago

Wouldn't this PR #38 fix this issue???

kforner commented 5 years ago

We could:

I could do a PR if you think that is a good idea.