REditorSupport / languageserver

An implementation of the Language Server Protocol for R
Other
581 stars 94 forks source link

Can't turn off linter #570

Closed JohnCoene closed 2 years ago

JohnCoene commented 2 years ago

Hi,

I've got "r.lsp.diagnostics": false but the linter is still linting. Has been working for ages but for some reason it no longer does. Is there something I am missing?

renkun-ken commented 2 years ago

I cannot reproduce the problem. Are you using the latest release of languageserver, lintr, and vscode-R?

JohnCoene commented 2 years ago

Sorry, I can't seem to be able to reproduce it either. Thanks again for the amazing suite of packages!

mihaiconstantin commented 2 years ago

I experience the same after the v2.5.3 update. The problem goes away if I toggle the R › Lsp: Diagnostics › Enable diagnostics. setting in VSCode. However, the problem is back upon running Developer: Reload Window. Until now, I was following your suggestion here, i.e., https://github.com/REditorSupport/languageserver/issues/544#issuecomment-1116873424.

mihaiconstantin commented 2 years ago

@renkun-ken I updated the packages you indicated, and no improvements, sadly. I rolled back to v2.5.2 and it works as expected.

JohnCoene commented 2 years ago

It's strange issue that I have trouble replicating myself

dsg38 commented 2 years ago

I have the same issue - and it can temporarily be fixed by toggling the setting as @mihaiconstantin has said (see below). But then returns whenever I reopen vs code. I'm on mac os 12.5.1, vs code 1.71.2, r extension 2.5.3

I experience the same after the v2.5.3 update. The problem goes away if I toggle the R › Lsp: Diagnostics › Enable diagnostics. setting if VSCode. However, the problem is back upon running Developer: Reload Window. Until now, I was following your suggestion here, i.e., #544 (comment).

vertesy commented 1 year ago

I have the same issue on macOS Ventura, VS code 1.80.2, extensionR v2.8.1, latest R installed. Following REditorSupport/vscode-R#1196 solved the issue. Thank you!