search

REditorSupport / languageserver

An implementation of the Language Server Protocol for R
Other
581 stars 94 forks source link

Include all exports in namespace objects #591

Closed renkun-ken closed 1 year ago

renkun-ken commented 1 year ago

Closes #590

objects(ns) does not include all exports such as rvest::read_html() (from xml2) and purrr:set_names() (from rlang). This PR makes the Namespace object include all namespace objects and all exports (not necessarily live in the same namespace).

randy3k commented 1 year ago

Oh, you are 4 minutes faster than mine, I have just pushed https://github.com/REditorSupport/languageserver/tree/reexport And our commits are basically the same :)

renkun-ken commented 1 year ago

Oh, you are 4 minutes faster than mine, I have just pushed https://github.com/REditorSupport/languageserver/tree/reexport And our commits are basically the same :)

Didn't notice your commits while adding a test case for this. 😄