search

REditorSupport / vscode-R

R Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=REditorSupport.r
MIT License
1.06k stars 125 forks source link

Data viewer with Tabulator #1485

Open albertosantini opened 6 months ago

albertosantini commented 6 months ago

Is your feature request related to a problem? Please describe. Data viewer is using ag-grid.

The load with a lot of rows is slow

  1. due to collecting and passing the content (dataframe) to ag-agrid?
  2. or due to the rendering of ag-grid because it is not virtual on client-side?

Describe the solution you'd like Anyone during software selection of ag-grid tried Tabulator lib? https://tabulator.info/

Describe alternatives you've considered It seems to me (if I am not wrong) it implements virtual dom on client side and may resolve the slowness if it is due to ag-grid rendering.

A few resources about virtual dom in Tabulator:

Additional context What do you think?

I was wondering because I don't want proposing a push request reinventing the wheel or just retrying an insuccess. ;)

eitsupi commented 6 months ago

I think the slow loading of data frames is due to the writing and reading of json files.

Perhaps using Arrow can speed up the process? However, since the arrow package is a very large dependency, we may need to wait until the nanoarrow package supports reading and writing Arrow files.

albertosantini commented 6 months ago

I think the slow loading of data frames is due to the writing and reading of json files.

I was afraid about that ^, anyway I investigate it a bit. Also I put in my radar nanoarrow.

Thanks @eitsupi.