RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

wrong syntax in SIGNALduino_Parse_MS & SIGNALduino_Parse_MC #1049

Closed HomeAutoUser closed 2 years ago

HomeAutoUser commented 2 years ago

examples:

2021.12.16 18:56:16.920 3: sduino_radino_433Mhz: Parse_MS, faulty rssi R=: xyz
2021.12.16 18:56:16.923 1: PERL WARNING: Use of uninitialized value $rssiStr in concatenation (.) or string at ./FHEM/00_SIGNALduino.pm line 2498.
2021.12.16 18:56:16.924 1: stacktrace:
2021.12.16 18:56:16.924 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2498)
2021.12.16 18:56:16.924 1:     main::SIGNALduino_Parse_MS          called by ./FHEM/00_SIGNALduino.pm (2980)
2021.12.16 18:56:16.924 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 18:56:16.924 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 18:56:16.924 1:     main::CallFn                        called by fhem.pl (773)

--------------------------------------------------------------------------------------------------------------

2021.12.16 19:12:10.139 3: sduino_nano_433Mhz: Parse_MC, faulty clock: asd;
2021.12.16 19:12:10.140 1: PERL WARNING: Use of uninitialized value $clock in numeric gt (>) at ./FHEM/00_SIGNALduino.pm line 2812.
2021.12.16 19:12:10.140 1: stacktrace:
2021.12.16 19:12:10.140 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2812)
2021.12.16 19:12:10.140 1:     main::SIGNALduino_Parse_MC          called by ./FHEM/00_SIGNALduino.pm (2989)
2021.12.16 19:12:10.140 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 19:12:10.141 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 19:12:10.141 1:     main::CallFn                        called by fhem.pl (773)

--------------------------------------------------------------------------------------------------------------

2021.12.16 19:15:02.396 3: sduino_nano_433Mhz: Parse_MC, faulty mcbitnum: bit;
2021.12.16 19:15:02.397 1: PERL WARNING: Use of uninitialized value $mcbitnum in numeric gt (>) at ./FHEM/00_SIGNALduino.pm line 2839.
2021.12.16 19:15:02.397 1: stacktrace:
2021.12.16 19:15:02.397 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2839)
2021.12.16 19:15:02.397 1:     main::SIGNALduino_Parse_MC          called by ./FHEM/00_SIGNALduino.pm (2989)
2021.12.16 19:15:02.397 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 19:15:02.397 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 19:15:02.397 1:     main::CallFn                        called by fhem.pl (773)

--------------------------------------------------------------------------------------------------------------

2021.12.16 19:17:26.419 3: sduino_nano_433Mhz: Parse_MC, faulty rawData D=: esel
2021.12.16 19:17:26.419 1: PERL WARNING: Use of uninitialized value $hlen in multiplication (*) at ./FHEM/00_SIGNALduino.pm line 2801.
2021.12.16 19:17:26.419 1: stacktrace:
2021.12.16 19:17:26.419 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2801)
2021.12.16 19:17:26.419 1:     main::SIGNALduino_Parse_MC          called by ./FHEM/00_SIGNALduino.pm (2989)
2021.12.16 19:17:26.419 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 19:17:26.420 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 19:17:26.420 1:     main::CallFn                        called by fhem.pl (773)
codecov[bot] commented 2 years ago

Codecov Report

Merging #1049 (60cedce) into master (5316b5d) will decrease coverage by 0.23%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   61.58%   61.35%   -0.24%     
==========================================
  Files         127      126       -1     
  Lines        9353     9328      -25     
  Branches     1479     1476       -3     
==========================================
- Hits         5760     5723      -37     
- Misses       2519     2534      +15     
+ Partials     1074     1071       -3     
Flag Coverage Δ
fhem 52.61% <100.00%> (-0.24%) :arrow_down:
modules 61.35% <100.00%> (-0.24%) :arrow_down:
perl 91.61% <ø> (-0.22%) :arrow_down:
unittests 61.35% <100.00%> (-0.24%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 63.17% <100.00%> (-0.65%) :arrow_down:
FHEM/lib/SD_Protocols.pm 79.17% <0.00%> (-0.58%) :arrow_down:
t/FHEM/14_SD_AS/00_load.t
t/FHEM/14_SD_UT/09_parseDatat.t
t/FHEM/14_BresserTemeo/00_load.t 100.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm 71.54% <0.00%> (+0.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5316b5d...60cedce. Read the comment docs.