Closed elektron-bbs closed 2 years ago
Merging #1061 (7352d87) into master (66d8afe) will increase coverage by
0.01%
. The diff coverage is55.55%
.
@@ Coverage Diff @@
## master #1061 +/- ##
==========================================
+ Coverage 61.96% 61.98% +0.01%
==========================================
Files 126 126
Lines 9271 9319 +48
Branches 1462 1474 +12
==========================================
+ Hits 5745 5776 +31
- Misses 2445 2450 +5
- Partials 1081 1093 +12
Flag | Coverage Δ | |
---|---|---|
fhem | 53.29% <55.55%> (+0.04%) |
:arrow_up: |
modules | 61.98% <55.55%> (+0.01%) |
:arrow_up: |
perl | 91.61% <ø> (+0.08%) |
:arrow_up: |
unittests | 61.98% <55.55%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
FHEM/lib/SD_ProtocolData.pm | 100.00% <ø> (ø) |
|
FHEM/14_SD_WS.pm | 63.79% <54.71%> (-0.36%) |
:arrow_down: |
FHEM/00_SIGNALduino.pm | 63.00% <100.00%> (ø) |
|
t/FHEM/14_SD_BELL/09_parseDatat.t | ||
t/FHEM/14_SD_WS07/09_parseDatat.t | 80.00% <0.00%> (ø) |
|
FHEM/lib/SD_Protocols.pm | 79.15% <0.00%> (+0.22%) |
:arrow_up: |
FHEM/10_SD_Rojaflex.pm | 71.54% <0.00%> (+0.40%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 66d8afe...7352d87. Read the comment docs.
@elektron-bbs
Sollten wir die Sensordaten nicht noch im SIGNALDUINO_Tool hinterlegen? Vorher wurde der Sensor doch nicht ordentlich empfangen oder?
Hab ich doch: https://github.com/RFD-FHEM/SIGNALduino_TOOL/commit/bf0d990f206e8a07af6f00d6a19c3540551afb4b https://github.com/RFD-FHEM/SIGNALduino_TOOL/commit/b65bce72c1e56e01a1e83942b089b1970ae930a8 Hatte nur vergessen, den Haken zu setzen :-)
OK, ich hatte das irgendwie nicht gesehen. Vermutlich auch mehr nach 116.1 gesucht :)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[ ] Bugfix (please link issue)
[x] Feature enhancement
[ ] Documentation update
[ ] Unittest enhancement
[ ] other
What is the current behavior? (You can also link to an open issue here, if this describes the current behavior) No decoding of the Thunder and lightning sensor Fine Offset WH57, aka Froggit DP60, aka Ambient Weather WH31L. Please refer: https://forum.fhem.de/index.php/topic,122527.0.html
What is the new behavior (if this is a feature change)? Decoding of the Thunder and lightning sensor Fine Offset WH57, aka Froggit DP60, aka Ambient Weather WH31L.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) no
Other information: