Closed sidey79 closed 2 years ago
Merging #1065 (14985d7) into master (11c8daf) will increase coverage by
0.09%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
+ Coverage 62.25% 62.34% +0.09%
==========================================
Files 126 126
Lines 9336 9340 +4
Branches 1475 1476 +1
==========================================
+ Hits 5812 5823 +11
+ Misses 2424 2416 -8
- Partials 1100 1101 +1
Flag | Coverage Δ | |
---|---|---|
fhem | 53.67% <80.00%> (+0.04%) |
:arrow_up: |
modules | 62.34% <80.00%> (+0.09%) |
:arrow_up: |
perl | 91.85% <ø> (+0.21%) |
:arrow_up: |
unittests | 62.34% <80.00%> (+0.09%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
lib/Test2/SIGNALduino/RDmsg.pm | 82.35% <75.00%> (-0.37%) |
:arrow_down: |
FHEM/14_SD_UT.pm | 37.97% <100.00%> (ø) |
|
t/FHEM/14_FLAMINGO/09_parseDatat.t | ||
t/FHEM/14_SD_BELL/09_parseDatat.t | 80.00% <0.00%> (ø) |
|
FHEM/lib/SD_Protocols.pm | 79.81% <0.00%> (+0.57%) |
:arrow_up: |
FHEM/10_SD_Rojaflex.pm | 72.76% <0.00%> (+1.21%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 11c8daf...14985d7. Read the comment docs.
warten auf #1069
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[x] Bugfix (please link issue)
[ ] Feature enhancement
[ ] Documentation update
[x] Unittest enhancement
[ ] other
What is the current behavior? (You can also link to an open issue here, if this describes the current behavior)
1) Es wird parseFN geprüft, aber nicht ob die dmsg auf den im Modul definierten Match Eintrag passt.
Es wird geprüft, ob die dmsg auf die regex in {Match} passt
-> Dabei ist aufgefallen dass in SD_UT die Match Regex nicht für die im Test enthaltenen getesteten Protokolle passt. Regex daher korrigiert / erweitert.
-> Für SD Rojaflex wurden Testdaten erweitert um einen gewollten mismatch erkenne zu können.
ich hoffe nicht