RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

Update {Match} regex for Hideki Module #1071

Closed sidey79 closed 2 years ago

sidey79 commented 2 years ago

Sensors with less data like temperature only, are not matched by the {Match} regex. As from FHEM Revision @25489 upwards, the .clientArray is no longer used for dispatch if a module is already loaded.

The {Match} regex accepts messages with less data, so the data will also be dispatched after the module has been loaded.

No

The {Match} regex is complied once the module is initalized and not for every check it's used by fhem

codecov[bot] commented 2 years ago

Codecov Report

Merging #1071 (1e4cf1d) into master (05cbfcf) will increase coverage by 1.38%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   62.18%   63.56%   +1.38%     
==========================================
  Files         126      128       +2     
  Lines        9340     9363      +23     
  Branches     1476     1477       +1     
==========================================
+ Hits         5808     5952     +144     
+ Misses       2431     2280     -151     
- Partials     1101     1131      +30     
Flag Coverage Δ
fhem 55.13% <90.90%> (+1.59%) :arrow_up:
modules 63.56% <90.90%> (+1.38%) :arrow_up:
perl 91.85% <ø> (+0.21%) :arrow_up:
unittests 63.56% <90.90%> (+1.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/14_Hideki/09_ParseData.t 88.88% <88.88%> (ø)
FHEM/14_Hideki.pm 50.93% <100.00%> (+46.26%) :arrow_up:
t/FHEM/10_SD_GT/00_load.t 100.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.81% <0.00%> (+0.57%) :arrow_up:
FHEM/00_SIGNALduino.pm 64.10% <0.00%> (+0.64%) :arrow_up:
FHEM/10_SD_Rojaflex.pm 71.13% <0.00%> (+2.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05cbfcf...1e4cf1d. Read the comment docs.

sidey79 commented 2 years ago

Warte auf #1065