Closed sidey79 closed 2 years ago
Merging #1084 (f8a2d6b) into master (8edcf22) will increase coverage by
0.06%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 63.60% 63.66% +0.06%
==========================================
Files 131 132 +1
Lines 9500 9524 +24
Branches 1505 1508 +3
==========================================
+ Hits 6042 6063 +21
Misses 2296 2296
- Partials 1162 1165 +3
Flag | Coverage Δ | |
---|---|---|
fhem | 55.51% <100.00%> (+0.19%) |
:arrow_up: |
modules | 63.66% <100.00%> (+0.06%) |
:arrow_up: |
perl | 90.59% <ø> (ø) |
|
unittests | 63.66% <100.00%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
FHEM/00_SIGNALduino.pm | 63.74% <100.00%> (+0.04%) |
:arrow_up: |
t/FHEM/00_SIGNALduino/01_SIGNALduino_Define.t | 100.00% <100.00%> (ø) |
|
t/FHEM/14_FLAMINGO/09_parseDatat.t | 80.00% <0.00%> (ø) |
|
FHEM/lib/SD_Protocols.pm | 79.56% <0.00%> (+0.10%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@elektron-bbs
Ich habe es noch nicht getestet und noch keinen Test erstellt, welcher den Fehler provoziert, aber das wäre meine Idee.
Ich glaube, das passt so. Bei meinen Versuchen hatte ich jetzt die richtigen SIGNALduinos in den Logs.
@elektron-bbs
Ich habe einen Test ergänzt, der diesen Fehler gefunden hat. Er wurde dadurch behoben. :)
Ich habe den Code noch etwas aufgeräumt. Nebenwirkungen vermute ich jetzt keine.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[x] Bugfix (please link issue)
[ ] Feature enhancement
[ ] Documentation update
[ ] Unittest enhancement
[ ] other
What is the current behavior? (You can also link to an open issue here, if this describes the current behavior)
1076
Every definition of SIGNALduino gets it's own protocol object
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: