RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

clone Protocol Object for every definition #1084

Closed sidey79 closed 2 years ago

sidey79 commented 2 years ago

1076

Every definition of SIGNALduino gets it's own protocol object

codecov[bot] commented 2 years ago

Codecov Report

Merging #1084 (f8a2d6b) into master (8edcf22) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   63.60%   63.66%   +0.06%     
==========================================
  Files         131      132       +1     
  Lines        9500     9524      +24     
  Branches     1505     1508       +3     
==========================================
+ Hits         6042     6063      +21     
  Misses       2296     2296              
- Partials     1162     1165       +3     
Flag Coverage Δ
fhem 55.51% <100.00%> (+0.19%) :arrow_up:
modules 63.66% <100.00%> (+0.06%) :arrow_up:
perl 90.59% <ø> (ø)
unittests 63.66% <100.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 63.74% <100.00%> (+0.04%) :arrow_up:
t/FHEM/00_SIGNALduino/01_SIGNALduino_Define.t 100.00% <100.00%> (ø)
t/FHEM/14_FLAMINGO/09_parseDatat.t 80.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.56% <0.00%> (+0.10%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

sidey79 commented 2 years ago

@elektron-bbs

Ich habe es noch nicht getestet und noch keinen Test erstellt, welcher den Fehler provoziert, aber das wäre meine Idee.

elektron-bbs commented 2 years ago

Ich glaube, das passt so. Bei meinen Versuchen hatte ich jetzt die richtigen SIGNALduinos in den Logs.

sidey79 commented 2 years ago

@elektron-bbs

Ich habe einen Test ergänzt, der diesen Fehler gefunden hat. Er wurde dadurch behoben. :)

Ich habe den Code noch etwas aufgeräumt. Nebenwirkungen vermute ich jetzt keine.