14_Hideki.pm - perlcritic

[HomeAutoUser]

• Please check if the PR fulfills these requirements
• [ ] Tests for the changes have been added / modified (needed for for bug fixes / features)
• [ ] commandref has been added / updated (needed for bug fixes / features)

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

• [ ] Bugfix (please link issue)

• [ ] Feature enhancement

• [ ] Documentation update

• [ ] Unittest enhancement

• [x] other

• What is the current behavior? (You can also link to an open issue here, if this describes the current behavior)

  • any reviewdog [perlcritic] reports

    FHEM/14_Hideki.pm|22 col 1| Subroutine prototypes used (See page 194 of PBP)
    FHEM/14_Hideki.pm|44 col 1| Subroutine prototypes used (See page 194 of PBP)
    FHEM/14_Hideki.pm|62 col 3| "return" statement with explicit "undef" (See page 199 of PBP)
    FHEM/14_Hideki.pm|66 col 1| Subroutine prototypes used (See page 194 of PBP)
    FHEM/14_Hideki.pm|71 col 3| "return" statement with explicit "undef" (See page 199 of PBP)
    FHEM/14_Hideki.pm|76 col 1| Subroutine prototypes used (See page 194 of PBP)

• What is the new behavior (if this is a feature change)?

  • no message on perlcritic level 5
  • less Messages onnlevel 4, 3 and 2

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

• Other information:

  • revised useless interpolation / hard tabs / "return" statement with explicit "undef" / commandref indent
  • replaced if-elsif-else code for sensor specific code with hash table
  • simple input validation
  • deduplicated code with getter subs

[codecov[bot]]

Codecov Report

Merging #1086 (2791dce) into master (4e9a692) will increase coverage by 0.36%. The diff coverage is 71.06%.

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
+ Coverage   67.15%   67.52%   +0.36%     
==========================================
  Files         133      136       +3     
  Lines        9816     9816              
  Branches     1577     1571       -6     
==========================================
+ Hits         6592     6628      +36     
+ Misses       1928     1892      -36     
  Partials     1296     1296              

Flag	Coverage Δ
fhem	57.13% <71.06%> (+0.43%)	:arrow_up:
modules	67.52% <71.06%> (+0.36%)	:arrow_up:
perl	90.33% <ø> (+0.16%)	:arrow_up:
unittests	67.52% <71.06%> (+0.36%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
FHEM/14_Hideki.pm	72.58% <70.88%> (+10.35%)	:arrow_up:
t/FHEM/14_Hideki/09_ParseData.t	94.11% <100.00%> (ø)
FHEM/00_SIGNALduino.pm	63.64% <0.00%> (-0.45%)	:arrow_down:
t/FHEM/10_SD_Rojaflex/09_parseData.t
t/FHEM/14_SD_AS/09_parseData.t	94.11% <0.00%> (ø)
t/FHEM/14_FLAMINGO/09_parseData.t	94.11% <0.00%> (ø)
t/FHEM/14_SD_AS/00_load.t	100.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm	71.25% <0.00%> (+5.26%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[HomeAutoUser]

Frohe Ostern @RFD-FHEM/mergemasters Euch allen.

@sidey79 , nach Ostern komme ich hier bestimmt voran ;)

[sidey79]

@HomeAutoUser

Wollen wir den PR zum Ende bringen?

[HomeAutoUser]

@HomeAutoUser

Wollen wir den PR zum Ende bringen?

Ja @sidey79 , ich scheute mich vorher immer diesen weiter zu machen um nicht zu viel Konflikte zu generieren bei den etlichen Branch’s welche offen waren.

[sidey79]

Ich denke aktuell gibt es nichts offenes Richtung Hideki

[HomeAutoUser]

@sidey79 - handheb and GoodNight ;-)

[sidey79]

@HomeAutoUser

Ich habe noch ein paar Perlcritic Meldungen mehr bearbeitet, was dazu führte, dass ich den Code etwas modularer gestaltet habe.

Die Readingnamen und Logausgaben stimmen dadurch jetzt auch überein was die Bezeichnung angeht.

[HomeAutoUser]

@HomeAutoUser

Ich habe noch ein paar Perlcritic Meldungen mehr bearbeitet, was dazu führte, dass ich den Code etwas modularer gestaltet habe.

Die Readingnamen und Logausgaben stimmen dadurch jetzt auch überein was die Bezeichnung angeht.

Ich habe den Umbau vernommen. Das Modul werde ich so mal Testlaufen lassen in meinem Hideki Dschungel.

PS: Happy New Year @sidey79 und all

[sidey79]

@HomeAutoUser

Sollen wir mal mergen?