RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

reviewdog for perl tests & errors - report unittest failure inline #1100

Closed sidey79 closed 1 year ago

sidey79 commented 2 years ago

Check perl errors and test results via reviewdog, to provide inline links to specific files.

don't push versiondate or changed back to repository if there is any failed check.

1) Errors from unittests are not displayed inline, we have to seek them in the job log manual. 2) Version and controls file are updated before tests have passed

1) check status report of perl errors (perl-errors) and check status report if unittest is failing (perl-test2-tap) 2) Version and control file upates will wait until successfull finished checks

I don't think so.

Exampe of a failed test:

Direct test result, linking to exact place where the test failed:

image

Exampe of syntax error in a module:

A link brings us directly to the line where the error is reported.

image
codecov[bot] commented 2 years ago

Codecov Report

Merging #1100 (101d9f8) into master (eccc246) will increase coverage by 0.42%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   64.66%   65.08%   +0.42%     
==========================================
  Files         135      138       +3     
  Lines        9723     9758      +35     
  Branches     1544     1547       +3     
==========================================
+ Hits         6287     6351      +64     
+ Misses       2221     2189      -32     
- Partials     1215     1218       +3     
Flag Coverage Δ
fhem 57.15% <66.66%> (+0.53%) :arrow_up:
modules 65.08% <66.66%> (+0.42%) :arrow_up:
perl 90.33% <ø> (+0.24%) :arrow_up:
unittests 65.08% <66.66%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t/FHEM/14_SD_WS/00_load.t 100.00% <ø> (ø)
FHEM/14_SD_WS07.pm 47.40% <66.66%> (ø)
t/FHEM/14_SD_BELL/00_load.t
t/FHEM/14_BresserTemeo/00_load.t
t/FHEM/14_SD_AS/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_FLAMINGO/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_SD_WS07/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/14_Hideki/00_load.t 100.00% <0.00%> (ø)
FHEM/14_SD_WS09.pm 73.07% <0.00%> (+8.17%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more