Closed sidey79 closed 2 years ago
Merging #1102 (0abe448) into master (ad11014) will increase coverage by
0.85%
. The diff coverage is85.57%
.
@@ Coverage Diff @@
## master #1102 +/- ##
==========================================
+ Coverage 63.93% 64.79% +0.85%
==========================================
Files 130 133 +3
Lines 9528 9637 +109
Branches 1515 1528 +13
==========================================
+ Hits 6092 6244 +152
+ Misses 2260 2204 -56
- Partials 1176 1189 +13
Flag | Coverage Δ | |
---|---|---|
fhem | 56.68% <71.15%> (+0.83%) |
:arrow_up: |
modules | 64.79% <85.57%> (+0.85%) |
:arrow_up: |
perl | 90.17% <85.57%> (-0.12%) |
:arrow_down: |
unittests | 64.79% <85.57%> (+0.85%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
FHEM/lib/SD_ProtocolData.pm | 100.00% <ø> (ø) |
|
t/FHEM/00_SIGNALduino/08_DeviceData_rmsg.t | 81.48% <ø> (ø) |
|
FHEM/lib/SD_Protocols.pm | 79.00% <71.15%> (-0.45%) |
:arrow_down: |
t/SD_Protocols/02_mc2dmc.t | 100.00% <100.00%> (ø) |
|
t/SD_Protocols/02_mcBit2Funkbus.t | 100.00% <100.00%> (ø) |
|
FHEM/10_SD_Rojaflex.pm | 68.69% <0.00%> (-2.85%) |
:arrow_down: |
t/FHEM/14_SD_WS07/09_parseDatat.t | ||
t/FHEM/10_SD_GT/00_load.t | 100.00% <0.00%> (ø) |
|
t/FHEM/14_FLAMINGO/09_parseDatat.t | 80.00% <0.00%> (ø) |
|
FHEM/00_SIGNALduino.pm | 65.27% <0.00%> (+1.53%) |
:arrow_up: |
... and 1 more |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
Muss das Modul nicht auch noch in der 00_SIGNALduino.pm in $clientsSIGNALduino und %matchListSIGNALduino eingetragen werden? Nachdem ich das getan habe und das Modul von Ralf9 aus dem Forum installiert habe, tut sich dann auch etwas:
2022.05.27 17:19:57 4: sduino_dummy IFB_Parse: typ=43 id=FAE8 fbState=C_1100 data=0000000000001000 channel=1 group=A act=D long=0
2022.05.27 17:19:57 2: sduino_dummy: IFB_Parse UNDEFINED sensor IFB43 detected, code IFB43_FAE8_A_1
Gibt es das Modul eigentlich auch irgendwo offiziell?
Hi @elektron-bbs
Ich habe das Modul nicht hinterlegt, da ich zunächst nur die Demodulation übernehmen wollte
Senden ist wohl auch noch interessant aber da war ich noch nicht.
@elektron-bbs
so, habe Angepasst. Sollen wir mal mergen und anschließend nach Testkandidaten ausschau halten? Die Signaldaten sind ja von einer fork firmware und daher nicht unbedingt exakt repräsentativ.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[ ] Bugfix (please link issue)
[x] Feature enhancement
[ ] Documentation update
[ ] Unittest enhancement
[ ] other
What is the current behavior?
Funkbus protocol can't be demodulated
Funkbus protocol shoud be demodulated Generic sub for demodulation manchester to differential manchester added
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Data is from forked firmware, and may not be correct.