HomeAutoUser commented 1 year ago

Please check if the PR fulfills these requirements
[ ] Tests for the changes have been added / modified (needed for for bug fixes / features)
[ ] commandref has been added / updated (needed for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[ ] Bugfix (please link issue)
[ ] Feature enhancement
[ ] Documentation update
[ ] Unittest enhancement
[x] other
What is the current behavior? (You can also link to an open issue here, if this describes the current behavior) TEST
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
for https://github.com/RFD-FHEM/SIGNALduino_TOOL/issues/87#issuecomment-1347183752

sidey79 commented 1 year ago

Das Problem https://github.com/RFD-FHEM/RFFHEM/actions/runs/3679607981/jobs/6224251293#step:7:32970 hängt mit #1129 zusammen, bzw. dass die Testdaten zu früh in den Branch "master" gepackt wurden.

HomeAutoUser commented 1 year ago

@sidey79 ich würde dies korrigieren. Zu früh übernommenen Daten nur im Pre und aus dem Master entfernen. Nur zur Absprache, nicht das wir beide drauf los legen ;-)

sidey79 commented 1 year ago

@HomeAutoUser

ich hab da jetzt nichts gemacht, die Daten müssen aus dem Master entfernt werden.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1131 (0530bc1) into master (946f0df) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   65.63%   65.60%   -0.04%     
==========================================
  Files         138      139       +1     
  Lines        9882     9887       +5     
  Branches     1572     1572              
==========================================
  Hits         6486     6486              
- Misses       2137     2142       +5     
  Partials     1259     1259

Flag	Coverage Δ
fhem	`57.87% <100.00%> (-0.04%)`	:arrow_down:
modules	`65.60% <100.00%> (-0.04%)`	:arrow_down:
perl	`90.33% <ø> (ø)`
unittests	`65.60% <100.00%> (-0.04%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
FHEM/10_SD_GT.pm	`40.09% <ø> (ø)`
FHEM/90_SIGNALduino_un.pm	`9.45% <ø> (ø)`
FHEM/00_SIGNALduino.pm	`63.74% <100.00%> (ø)`
FHEM/10_SD_Rojaflex.pm	`68.69% <0.00%> (-2.04%)`	:arrow_down:
t/FHEM/41_OREGON/09_parseData.t
t/FHEM/14_SD_BELL/00_load.t
t/FHEM/14_SD_AS/00_load.t	`100.00% <0.00%> (ø)`
t/FHEM/14_BresserTemeo/09_parseDatat.t	`80.00% <0.00%> (ø)`
t/FHEM/14_Hideki/00_load.t	`100.00% <0.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

RFD-FHEM / RFFHEM

TEST - only Update 90_SIGNALduino_un.pm #1131

Codecov Report