sidey79 commented 1 year ago

Please check if the PR fulfills these requirements
[ ] Tests for the changes have been added / modified (needed for for bug fixes / features)
[ ] commandref has been added / updated (needed for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[ ] Bugfix (please link issue)
[ ] Feature enhancement
[ ] Documentation update
[ ] Unittest enhancement
[x] other
What is the current behavior? (You can also link to an open issue here, if this describes the current behavior)

perlcritic 5 finds many subroutine prototypes messages:

./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 647, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 1010, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 2105, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 2530, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 2969, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3072, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3094, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3232, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3345, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3548, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3617, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/00_SIGNALduino.pm: Subroutine prototypes used at line 3686, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_AS.pm: Subroutine prototypes used at line 20, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_AS.pm: Subroutine prototypes used at line 67, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_AS.pm: Subroutine prototypes used at line 87, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_AS.pm: Subroutine prototypes used at line 96, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_AS.pm: Subroutine prototypes used at line 278, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS07.pm: Subroutine prototypes used at line 59, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS07.pm: Subroutine prototypes used at line 80, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS07.pm: Subroutine prototypes used at line 92, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 53, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 75, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 85, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 480, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 636, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 643, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 656, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 664, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS09.pm: Subroutine prototypes used at line 682, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS_Maverick.pm: Subroutine prototypes used at line 49, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS_Maverick.pm: Subroutine prototypes used at line 82, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS_Maverick.pm: Subroutine prototypes used at line 247, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS_Maverick.pm: Subroutine prototypes used at line 262, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS_Maverick.pm: Subroutine prototypes used at line 270, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/14_SD_WS_Maverick.pm: Subroutine prototypes used at line 278, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/41_OREGON.pm: Subroutine prototypes used at line 66, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/41_OREGON.pm: Subroutine prototypes used at line 88, column 1.  See page 194 of PBP.  (Severity: 5)
./FHEM/41_OREGON.pm: Subroutine prototypes used at line 897, column 1.  See page 194 of PBP.  (Severity: 5)

What is the new behavior (if this is a feature change)?

prototype warnings are removed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

Other information:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1145 (7503449) into master (0691346) will decrease coverage by 0.15%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
- Coverage   67.38%   67.23%   -0.16%     
==========================================
  Files         137      135       -2     
  Lines        9828     9818      -10     
  Branches     1572     1572              
==========================================
- Hits         6623     6601      -22     
- Misses       1914     1926      +12     
  Partials     1291     1291

Flag	Coverage Δ
fhem	`56.80% <100.00%> (-0.20%)`	:arrow_down:
modules	`67.23% <100.00%> (-0.16%)`	:arrow_down:
perl	`90.33% <ø> (ø)`
unittests	`67.23% <100.00%> (-0.16%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
FHEM/14_SD_AS.pm	`55.90% <ø> (ø)`
FHEM/14_SD_WS07.pm	`48.17% <ø> (ø)`
FHEM/14_SD_WS09.pm	`75.35% <ø> (ø)`
FHEM/14_SD_WS_Maverick.pm	`63.04% <ø> (ø)`
FHEM/41_OREGON.pm	`28.85% <ø> (ø)`
FHEM/00_SIGNALduino.pm	`64.09% <100.00%> (ø)`
FHEM/10_SD_Rojaflex.pm	`66.39% <0.00%> (-4.86%)`	:arrow_down:
t/FHEM/14_FLAMINGO/09_parseData.t
t/FHEM/14_SD_UT/00_load.t
t/FHEM/14_Hideki/00_load.t
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sidey79 commented 1 year ago

@elektron-bbs

Ich brauch ein neues Review wegen branch update

RFD-FHEM / RFFHEM

Removed prototypes #1145

Codecov Report