RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

Fix more percritic in 00_SIGNALduino.pm #1148

Open sidey79 opened 1 year ago

sidey79 commented 1 year ago

fileopen and sleep critic 5 fixed

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.49%. Comparing base (78b80d0) to head (295cb07).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1148 +/- ## ========================================== + Coverage 88.92% 89.49% +0.56% ========================================== Files 43 43 Lines 2466 2466 Branches 170 170 ========================================== + Hits 2193 2207 +14 + Misses 119 105 -14 Partials 154 154 ``` | [Flag](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1148/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | Coverage Δ | | |---|---|---| | [fhem](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `89.49% <ø> (+0.56%)` | :arrow_up: | | [modules](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `89.49% <ø> (+0.56%)` | :arrow_up: | | [perl](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `89.49% <ø> (+0.56%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `89.49% <ø> (+0.56%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HomeAutoUser commented 1 year ago

Sehe ich das richtig, dieser PR ist auch noch offen mit einem Review oder kommt hier noch mehr hinzu?

sidey79 commented 1 year ago

Ja, da ich an den Fileopen Dingen was verändert habe, muss das noch in echt getestet werden.