RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

Inkbird IBS-P01R Pool Thermometer #1149

Closed elektron-bbs closed 1 year ago

elektron-bbs commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #1149 (8af7810) into master (a4040b1) will increase coverage by 0.42%. The diff coverage is 74.28%.

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   66.92%   67.35%   +0.42%     
==========================================
  Files         133      135       +2     
  Lines        9784     9838      +54     
  Branches     1572     1577       +5     
==========================================
+ Hits         6548     6626      +78     
+ Misses       1945     1916      -29     
- Partials     1291     1296       +5     
Flag Coverage Δ
fhem 56.96% <74.28%> (+0.51%) :arrow_up:
modules 67.35% <74.28%> (+0.42%) :arrow_up:
perl 90.33% <ø> (+0.24%) :arrow_up:
unittests 67.35% <74.28%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/14_SD_WS.pm 68.33% <73.52%> (+0.22%) :arrow_up:
FHEM/00_SIGNALduino.pm 64.09% <100.00%> (+0.44%) :arrow_up:
t/FHEM/14_SD_AS/00_load.t
t/FHEM/14_FLAMINGO/09_parseData.t
t/FHEM/14_SD_UT/00_load.t 100.00% <0.00%> (ø)
t/FHEM/10_SD_Rojaflex/09_parseData.t 94.11% <0.00%> (ø)
t/FHEM/14_Hideki/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_SD_AS/09_parseData.t 94.11% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 78.48% <0.00%> (+0.41%) :arrow_up:
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

HomeAutoUser commented 1 year ago

@sidey79 | @elektron-bbs kann es durchaus möglich sein, das hier bei den Tests etwas durch die Lappen ging?

Hier gibt es einen Schlüssel welcher nur test beziffert ist. Überall heißt dieser tests wo auch setreadings definiert wurden. https://github.com/RFD-FHEM/RFFHEM/blob/master/t/FHEM/14_SD_WS/testData.json#L234:L244

Bitte mal prüfen.

elektron-bbs commented 1 year ago

Sieht so aus, ist schon seit Dezember so drin: https://github.com/RFD-FHEM/RFFHEM/commit/0cbecba665b9b4387c98123796efbd62a8fd3537 Betrifft aber BRESSER 6-in-1.

sidey79 commented 1 year ago

Ja, da fehlt ein s