Closed sidey79 closed 1 year ago
Merging #1150 (f641dcf) into master (89ead26) will increase coverage by
0.15%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
+ Coverage 67.04% 67.20% +0.15%
==========================================
Files 132 134 +2
Lines 9811 9833 +22
Branches 1577 1577
==========================================
+ Hits 6578 6608 +30
+ Misses 1937 1929 -8
Partials 1296 1296
Flag | Coverage Δ | |
---|---|---|
fhem | 56.78% <66.66%> (+0.20%) |
:arrow_up: |
modules | 67.20% <66.66%> (+0.15%) |
:arrow_up: |
perl | 90.33% <ø> (ø) |
|
unittests | 67.20% <66.66%> (+0.15%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
t/FHEM/00_SIGNALduino/01_SIGNALduino_Set_sendMsg.t | 100.00% <ø> (ø) |
|
FHEM/00_SIGNALduino.pm | 64.09% <66.66%> (+0.44%) |
:arrow_up: |
t/FHEM/14_FLAMINGO/09_parseData.t | 94.11% <0.00%> (ø) |
|
t/FHEM/14_BresserTemeo/00_load.t | 100.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
https://forum.fhem.de/index.php?topic=58396.new;topicseen#new
SIGNALduino_Set_sendMsg
If the protocol doesn't has a default frequency set but one is provided via parameter, then the freqency will not be set on the uC during wrong used schema.
If the protocol has a default frequency set and one is provided via parameters, then the frequency from the protocol was used instead of the given one.
What is the new behavior (if this is a feature change)?
If the protocol doesn't has a default frequency set but one is provided via parameter, then the freqency will be set within the uC (correct schema is used)
If the protocol has a default frequency set and one is provided via parameters, then the frequency from the parameters are prefered.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Maybe if someone has wrong freqency settings in the sendCmd, this will break functionality