RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

Master ade ws1907 #1153

Closed sidey79 closed 1 year ago

sidey79 commented 1 year ago

round sub isn't reliable

round is used from a package

no

sidey79 commented 1 year ago

@elektron-bbs

Was soll mit der Anpassung von start passieren?

codecov[bot] commented 1 year ago

Codecov Report

Merging #1153 (5c0a3c7) into master (4e9a692) will decrease coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   67.15%   67.08%   -0.08%     
==========================================
  Files         133      132       -1     
  Lines        9816     9797      -19     
  Branches     1577     1576       -1     
==========================================
- Hits         6592     6572      -20     
- Misses       1928     1930       +2     
+ Partials     1296     1295       -1     
Flag Coverage Δ
fhem 56.59% <100.00%> (-0.12%) :arrow_down:
modules 67.08% <100.00%> (-0.08%) :arrow_down:
perl 90.17% <ø> (ø)
unittests 67.08% <100.00%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/00_SIGNALduino.pm 63.90% <100.00%> (-0.19%) :arrow_down:
t/FHEM/10_SD_Rojaflex/09_parseData.t
t/FHEM/10_SD_GT/00_load.t
t/FHEM/14_SD_AS/00_load.t 100.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm 66.39% <0.00%> (+0.40%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

elektron-bbs commented 1 year ago

Ich denke, aufgrund der Antwort von @duko1234 im Beitrag https://github.com/RFD-FHEM/RFFHEM/issues/1147#issuecomment-1385962993, können wir auf diese Änderung verzichten.

sidey79 commented 1 year ago

@elektron-bbs Alles klar, ich mache neu auf, nur für round :)