RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

Replace round main with round in FHEM::Core::Utils::Math #1154

Closed sidey79 closed 1 year ago

sidey79 commented 1 year ago

The round sub from 98_Utils isn't reliable, because it can be overriden via POSIX or Math::Round package.

round from package FHEM::Core::Utils::Math is used which lives in a separate package and is not set into main

This module will stop working until fhem is updated to rev 27076 or newer: https://svn.fhem.de/trac/browser/trunk/fhem/lib/FHEM/Core/Utils/Math.pm?rev=27076

codecov[bot] commented 1 year ago

Codecov Report

Merging #1154 (5e1beef) into master (261f202) will increase coverage by 0.34%. The diff coverage is 89.58%.

@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   67.36%   67.70%   +0.34%     
==========================================
  Files         134      136       +2     
  Lines        9806     9829      +23     
  Branches     1571     1570       -1     
==========================================
+ Hits         6606     6655      +49     
+ Misses       1904     1879      -25     
+ Partials     1296     1295       -1     
Flag Coverage Δ
fhem 57.37% <89.58%> (+0.42%) :arrow_up:
modules 67.70% <89.58%> (+0.34%) :arrow_up:
perl 90.33% <ø> (+0.16%) :arrow_up:
unittests 67.70% <89.58%> (+0.34%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_WS09.pm 75.89% <78.26%> (+0.53%) :arrow_up:
FHEM/00_SIGNALduino.pm 64.25% <100.00%> (+0.60%) :arrow_up:
FHEM/14_SD_AS.pm 56.25% <100.00%> (+0.34%) :arrow_up:
FHEM/14_SD_WS.pm 68.36% <100.00%> (+0.03%) :arrow_up:
t/FHEM/14_BresserTemeo/00_load.t
t/FHEM/10_SD_Rojaflex/09_parseData.t
t/FHEM/14_SD_UT/09_parseData.t 94.11% <0.00%> (ø)
t/FHEM/10_SD_GT/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_Hideki/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_SD_WS/09_parseData.t 94.11% <0.00%> (ø)
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more