RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
45 stars 33 forks source link

new remote control RCnoName20_09 #1261

Closed elektron-bbs closed 4 months ago

elektron-bbs commented 4 months ago
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (5781409) to head (393abe5).

Files Patch % Lines
FHEM/14_SD_UT.pm 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1261 +/- ## ========================================== + Coverage 70.36% 71.74% +1.37% ========================================== Files 137 139 +2 Lines 10128 10150 +22 Branches 1585 1586 +1 ========================================== + Hits 7127 7282 +155 + Misses 1677 1551 -126 + Partials 1324 1317 -7 ``` | [Flag](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1261/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | Coverage Δ | | |---|---|---| | [fhem](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `62.45% <50.00%> (+1.61%)` | :arrow_up: | | [modules](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `71.74% <50.00%> (+1.37%)` | :arrow_up: | | [perl](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `89.29% <ø> (+0.20%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/RFD-FHEM/RFFHEM/pull/1261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM) | `71.74% <50.00%> (+1.37%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RFD-FHEM#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elektron-bbs commented 4 months ago

Ich habe jetzt alles mögliche probiert, aber diese Meldung von codecov bekomme ich nicht weg:

codecov/patch Failing after 1s — 50.00% of diff hit (target 62.92%)
elektron-bbs commented 4 months ago

Ob die vielen #uncoverable branch wirklich gerechtfertigt sind, weiss ich nicht, aber der Testumfang sieht ja schon sehr gut aus und die Anpassungen sind ja eher geringer Natur.

Naja, die waren eher aus Verzweiflung, weil ich herausfinden wollte, warum cover mäkelt. Auf jeden Fall verbessern sie jetzt die Gesamtbilanz :-)

Wenn ich mergen soll, weil der Fehler mit der Patchabdeckung es nicht zulässt bitte melden.

Hat geklappt...